feat(sequencers): validate sequencer unbonding_time greater than dispute_period
#1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omritoptix
changed the title
danwt
previously approved these changes
Aug 20, 2024
…nbondingtime-greater-then-disputeperiod
omritoptix
changed the title
unbonding_time greater then dispute_period
…nbondingtime-greater-then-disputeperiod
zale144
requested changes
Aug 24, 2024
| @@ -153,7 +163,7 @@ func (am AppModule) ExportGenesis(ctx sdk.Context, cdc codec.JSONCodec) json.Raw | |||
| } | |||
|
|
|||
| // ConsensusVersion implements ConsensusVersion. | |||
| func (AppModule) ConsensusVersion() uint64 { return 2 } | |||
| func (AppModule) ConsensusVersion() uint64 { return 3 } | |||
zale144
changed the title
unbonding_time greater then dispute_periodunbonding_time greater than dispute_period
zale144
requested changes
Aug 29, 2024
| // Get the time duration of the dispute period | ||
| disputeDuration := time.Duration(rollappParams.DisputePeriodInBlocks) * HubExpectedTimePerBlock // dispute period duration | ||
| if params.UnbondingTime < disputeDuration { | ||
| return errorsmod.Wrapf(gerrc.ErrInvalidArgument, "unbonding time must be greater than dispute period") |
There was a problem hiding this comment.
this doesn't check if they are equal
omritoptix
reviewed
Aug 31, 2024
There was a problem hiding this comment.
I see segregation in migration where some are done in upgrade.go and some in dedicated migration.go file within the sequencer module.
wondering why is that.
opened an issue for that here: #1160
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
==========================================
- Coverage 28.22% 27.39% -0.83%
==========================================
Files 332 456 +124
Lines 52494 82936 +30442
==========================================
+ Hits 14818 22724 +7906
- Misses 35346 57305 +21959
- Partials 2330 2907 +577 ☔ View full report in Codecov by Sentry. |
omritoptix
previously approved these changes
Aug 31, 2024
omritoptix
deleted the
mtsitrin/613-sequencers-validate-sequencer-unbondingtime-greater-then-disputeperiod
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #613
This PR:
x/sequencerto have params in own store instead of deprecatedx/params