revert(streamer): don't distribute abstained part of sponsored distri… #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
reviewed
Aug 20, 2024
Comment on lines
41
to
73
| func DistrInfoFromDistribution(d sponsorshiptypes.Distribution) *DistrInfo { | ||
| totalWeight := math.ZeroInt() | ||
|
|
||
| records := make([]DistrRecord, 0, len(d.Gauges)) | ||
| for _, g := range d.Gauges { | ||
| records = append(records, DistrRecord{ | ||
| GaugeId: g.GaugeId, | ||
| Weight: g.Power, | ||
| }) | ||
| totalWeight = totalWeight.Add(g.Power) | ||
| } | ||
|
|
||
| return &DistrInfo{ | ||
| TotalWeight: d.VotingPower, | ||
| TotalWeight: totalWeight, | ||
| Records: records, | ||
| } | ||
| } |
There was a problem hiding this comment.
This is very subtle so IMO it would be a good idea to explain the precise intended behavior in more detail the docstring. Especially since it has changed couple times
keruch
force-pushed
the
kirill/1095-sponsored-streams-distr-revert
branch
from
62bb593
to
0a13b9a
Compare
omritoptix
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert of #1097 due to the Omri request.
Closes #1095
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
For Reviewer:
After reviewer approval: