fix(validator set): use comet compatible API for validators set wrt hash #1159
+82
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsitrin
approved these changes
Oct 21, 2024
keruch
reviewed
Oct 21, 2024
Comment on lines
+45
to
+55
| func (s Sequencer) TMValidator() *types.Validator { | ||
| return &s.val | ||
| } | ||
|
|
||
| func (s Sequencer) TMValidators() []*types.Validator { | ||
| return []*types.Validator{s.TMValidator()} | ||
| } | ||
|
|
||
| func (s Sequencer) TMValset() (*types.ValidatorSet, error) { | ||
| return types.ValidatorSetFromExistingValidators(s.TMValidators()) | ||
| } |
There was a problem hiding this comment.
what do you think about removing dependencies between methods? otherwise you may end up refactoring multiple methods after changing one of them. also such deps generate additional function usages. for me it's a bit confusing when i want to promptly iterate through all usages and i see a giant list with deep call hierarchy.
Suggested change
| func (s Sequencer) TMValidator() *types.Validator { | |
| return &s.val | |
| } | |
| func (s Sequencer) TMValidators() []*types.Validator { | |
| return []*types.Validator{s.TMValidator()} | |
| } | |
| func (s Sequencer) TMValset() (*types.ValidatorSet, error) { | |
| return types.ValidatorSetFromExistingValidators(s.TMValidators()) | |
| } | |
| func (s Sequencer) TMValidator() *types.Validator { | |
| return &s.val | |
| } | |
| func (s Sequencer) TMValidators() []*types.Validator { | |
| return []*types.Validator{&s.val} | |
| } | |
| func (s Sequencer) TMValset() (*types.ValidatorSet, error) { | |
| return types.ValidatorSetFromExistingValidators([]*types.Validator{&s.val}) | |
| } |
There was a problem hiding this comment.
decline
not important
anyways you supposed to implement stuff in terms of other things. e.g. if TmValidator() changed then TMValidators and TmValset does not change
If you make TmValset and Tmvalidators also do TmValidator from scratch then you change 3x if that calculation changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it should work, I haven't e2e tested it
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close ##1134
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: