Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not define filename as string literal #35

Merged
merged 10 commits into from
Oct 11, 2024
Merged

fix: do not define filename as string literal #35

merged 10 commits into from
Oct 11, 2024

Conversation

matteo-cristino
Copy link
Contributor

String literal are seaved as read only data

@matteo-cristino matteo-cristino marked this pull request as draft October 6, 2024 11:02
@jaromil
Copy link
Member

jaromil commented Oct 7, 2024

Oh wow!!! you fixed a lot

@matteo-cristino
Copy link
Contributor Author

Almost there 🤞

@matteo-cristino
Copy link
Contributor Author

Remaining problems:

  • rm_ftw breaks on removing directories and results in
Error: remove path C:\Users\RUNNER~1\AppData\Local\Temp\CJIT-UAWstjjzLyowjyeG/sec_api
Permission denied
Error: nftw path C:\Users\RUNNER~1\AppData\Local\Temp\CJIT-UAWstjjzLyowjyeG
Permission denied
  • cjit is terminated before the code execution ends, for example the output of hello.c is
CJIT 
Source to execute: test\hello.c
Loading source file test\hello.c
Compilation successful
Execution start
---
---
Execution completed
Hello World!

@matteo-cristino
Copy link
Contributor Author

Since the print of output in the correct order seems to not have a quick solution, will create a issue and work on it on another PR to avoid having conflicts in this PR that already fixes quite some window problems

@matteo-cristino matteo-cristino marked this pull request as ready for review October 9, 2024 09:57
@jaromil
Copy link
Member

jaromil commented Oct 11, 2024

awesome!!!!! you rock

@jaromil jaromil merged commit bef945a into main Oct 11, 2024
10 checks passed
@jaromil jaromil deleted the fix/windows branch October 11, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants