Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CMakeLists.txt: install all headers from the include dir #190

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix CMakeLists.txt: install all headers from the include dir #190

merged 2 commits into from
Jul 22, 2024

Conversation

rautyrauty
Copy link
Contributor

All of them may be required.

@rautyrauty
Copy link
Contributor Author 

`-- usr
    |-- include
    |   |-- frei0r
    |   |   |-- blur.h
    |   |   |-- cairo.h
    |   |   |-- cfc.h
    |   |   |-- colorspace.h
    |   |   `-- math.h
    |   |-- frei0r.h
    |   `-- frei0r.hpp

@rautyrauty
Copy link
Contributor Author

@jaromil review please

@rautyrauty
Copy link
Contributor Author

@jaromil run the test again

@rautyrauty
Move the auxiliary libraries to a separate directory
dfba758 
This is necessary in order to avoid clogging the system
directory. It will also be easier to put these libraries
in a separate distribution package.
@rautyrauty
Copy link
Contributor Author

@jaromil one more time, please

@rautyrauty
Copy link
Contributor Author

@jaromil review please

jaromil
jaromil approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jaromil jaromil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty good improvement to standardization and portability, also makes plugin header inclusion more readable by easily distinguishing between frei0r ones and external. Will watch closely next days if something breaks downhill..

@jaromil jaromil merged commit e7fa53f into dyne:master Jul 22, 2024
2 checks passed
@rautyrauty rautyrauty deleted the fix-cmake-install branch July 22, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaromil jaromil jaromil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rautyrauty @jaromil