Implement keyholder test case #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to freeze the object, but decided that it wasn't worth it, but apparently forgot to remove the comment.
I decided that it is more clear this way.
Clarify the usage of getIgnoredStatements().
Rename it to ZenroomOutput.
Convert the JSON string to a JS object before we return it.
Fix the name of the function being tested in the description.
I think this better captures my intention.
Add missing no-non-null-assertion comments.
Return the Zenroom output along with the ignored statements in getIgnoredStatements.
Due to the recently-introduced changes to getIgnoredStatements(), we apply changes to tests as well.
Due to the recently-introduced changes to getIgnoredStatements(), we apply changes to tests as well.
Add the tokens: - I - Given - When - Then each of which, except for I, is case-insensitive, as also done in Zenroom.
Explicitly mark a TypeScript type with the "type" keyword.
We now use the shared Then and I. I also removed And statements due to their complexity.
They are too complex to deal with right just now.
Revert back changes to getIgnoredStatements(). I had planned the API little bit differently at first. I thought I should get the execution result along with the ignored statements, but it wasn't quite right. What needs to be done follows like this: - Get ignored statements - Decide whether the individual statements must run before or after the actual execution - Execute the before statements and save the output - Execute the "actual execution" using the provided data and the data you get from executing the before statements using the provided data and the data you get from executing the before statements merged together, and save the output - Execute the after statements, merge the output with the data you get from the actual execution, and save it - Return the output to the API consumer.
Due to I reverted my previous changes, we need to apply previous changes back!
Due to I reverted my previous changes, we need to apply previous changes back!
This test case supposed to test for creating public/secret keypairs and saving them to files. It was a bit complicated to do so, so we are generating random string and saving that to a file instead.
denizenging
force-pushed
the
sf/keyholder
branch
from
11d757e
to
3a6e145
Compare
The previous *.ts includes *.test.ts files, so the latter was unnecessary.
Because we don't wanna require each and every library user of us to add tslib to their dependencies.
This requires each subpackage to have another package.json changing its type.
This module introduces a method to use plugins defined in subpackages, and use that to create your own dialect of Zencode.
Convert the fs module and its example(s) to use the recently-introduced core module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.