Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add host override for any number of hosts #1014

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

nandor-magyar
Copy link
Contributor

I wanted to use our CLI to set up everything, but not use the default hardcoded localhost as host header. Unfortunately, that was not possible. Here is the implementation to do so, with some usage guidelines included in the Makefile.

@nandor-magyar nandor-magyar requested a review from a team as a code owner November 15, 2024 15:36
@github-actions github-actions bot added pr:feat source:cli The scope of the issue or pull request is CLI tool. lang:golang lang:makefile source:build Makefiles, Dockerfiles, etc and removed pr:feat labels Nov 15, 2024
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, LGTM.

@github-actions github-actions bot added the source:ci Workflow files label Nov 19, 2024
@github-actions github-actions bot removed the source:ci Workflow files label Nov 19, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 23.07692% with 20 lines in your changes missing coverage. Please review.

Project coverage is 24.40%. Comparing base (c592368) to head (3d301d6).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
golang/pkg/cli/container_defaults.go 35.29% 11 Missing ⚠️
golang/pkg/cli/cli.go 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1014      +/-   ##
===========================================
+ Coverage    24.34%   24.40%   +0.06%     
===========================================
  Files           77       77              
  Lines         8104     8124      +20     
===========================================
+ Hits          1973     1983      +10     
- Misses        5972     5982      +10     
  Partials       159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web. lang:typescript labels Nov 21, 2024
@github-actions github-actions bot added the source:ci Workflow files label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:golang lang:makefile lang:typescript pr:feat source:agent The scope of the issue or pull request is agent. source:build Makefiles, Dockerfiles, etc source:ci Workflow files source:cli The scope of the issue or pull request is CLI tool. source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants