-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add host override for any number of hosts #1014
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature, LGTM.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1014 +/- ##
===========================================
+ Coverage 24.34% 24.40% +0.06%
===========================================
Files 77 77
Lines 8104 8124 +20
===========================================
+ Hits 1973 1983 +10
- Misses 5972 5982 +10
Partials 159 159 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I wanted to use our CLI to set up everything, but not use the default hardcoded
localhost
as host header. Unfortunately, that was not possible. Here is the implementation to do so, with some usage guidelines included in the Makefile.