Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added hey cli project #628

Merged
merged 1 commit into from
Dec 30, 2024
Merged

feat: added hey cli project #628

merged 1 commit into from
Dec 30, 2024

Conversation

ZibanPirate
Copy link
Member

@ZibanPirate ZibanPirate commented Dec 30, 2024

added https://github.com/ZibanPirate/hey-cli

  • Bug fix
  • New feature
  • Other

@github-actions github-actions bot added project Project data Data related changes ( data folder ) labels Dec 30, 2024
@ZibanPirate ZibanPirate requested a review from a team December 30, 2024 14:37
"name": "hey-cli"
}
],
"tags": ["by-algerian"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this file as well? data/models/documentation/About_dzcode_io/Add_Your_Project_To_dzcode_io/content.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally didn't change it in the implementation PR, because tags are not something the contributor should worry about, but let me know what your are thoughts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh so you want the reviewer to add this information?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more like add a comment about it and let the author address it, this way, the contributor has a lower barrier to creating a PR, and then later we add comments it will be easier to apply the suggestions the reviewer commented

@ZibanPirate ZibanPirate merged commit 77edcff into main Dec 30, 2024
22 checks passed
@ZibanPirate ZibanPirate deleted the project/hey-cli branch December 30, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Data related changes ( data folder ) project Project
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants