GH-2170 Allow custom authenticators to be registered (#2170)

* Allow custom authenticators to be registered * fix test
dzikoysk · Jul 11, 2024 · 512570c · 512570c
1 parent d5714e5
commit 512570c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/reposilite-backend/src/main/kotlin/com/reposilite/auth/AuthenticationFacade.kt b/reposilite-backend/src/main/kotlin/com/reposilite/auth/AuthenticationFacade.kt
@@ -35,7 +35,7 @@ import java.util.concurrent.TimeUnit.MINUTES
 
 class AuthenticationFacade(
     private val journalist: Journalist,
-    private val authenticators: List<Authenticator>,
+    private val authenticators: MutableList<Authenticator>,
     private val accessTokenFacade: AccessTokenFacade
 ) : Journalist, Facade {
 
@@ -44,6 +44,10 @@ class AuthenticationFacade(
         .expireAfterAccess(1, MINUTES)
         .build()
 
+    fun registerAuthenticator(authenticator: Authenticator) {
+        this.authenticators.add(authenticator)
+    }
+
     fun authenticateByCredentials(credentials: Credentials): Result<out AccessTokenDto, ErrorResponse> =
         authenticationCache.getIfPresent(credentials)
             ?.asSuccess()

diff --git a/...ilite-backend/src/main/kotlin/com/reposilite/auth/application/AuthenticationComponents.kt b/...ilite-backend/src/main/kotlin/com/reposilite/auth/application/AuthenticationComponents.kt
@@ -47,13 +47,13 @@ class AuthenticationComponents(
             disableUserPasswordAuthentication = disableUserPasswordAuthentication,
         )
 
-    private fun authenticators(): List<Authenticator> =
-        listOf(
+    private fun authenticators(): MutableList<Authenticator> =
+        arrayListOf(
             basicAuthenticator(),
             ldapAuthenticator()
         )
 
-    fun authenticationFacade(authenticators: List<Authenticator> = authenticators()): AuthenticationFacade =
+    fun authenticationFacade(authenticators: MutableList<Authenticator> = authenticators()): AuthenticationFacade =
         AuthenticationFacade(
             journalist = journalist,
             authenticators = authenticators,

diff --git a/...-backend/src/test/kotlin/com/reposilite/auth/specification/AuthenticationSpecification.kt b/...-backend/src/test/kotlin/com/reposilite/auth/specification/AuthenticationSpecification.kt
@@ -36,7 +36,7 @@ internal abstract class AuthenticationSpecification : AccessTokenSpecification()
     fun createAuthenticationFacade() {
         this.authenticationFacade = AuthenticationFacade(
             journalist = logger,
-            authenticators = listOf(
+            authenticators = mutableListOf(
                 BasicAuthenticator(accessTokenFacade),
                 LdapAuthenticator(
                     journalist = logger,