Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overall progress label #57

Merged
merged 2 commits into from
May 17, 2019
Merged

Overall progress label #57

merged 2 commits into from
May 17, 2019

Conversation

JonathanTreffler
Copy link
Collaborator

I think it would be cool to have a label that shows the overall progress of the flowupload upload. So i added it.
The flow object already has a progress function.
I just added a function to the flow object that returns the number of files being uploaded (including already finished files) to be able to hide the progress label if there are no files selected.
Its a really small change but i think its quite nice to have.
I often use flowupload to upload hundreds of Gigabyte and i dont want to scroll over the whole page to see the progress

Screenshot_20190504_164534

@e-alfred
Copy link
Owner

e-alfred commented May 5, 2019

Thanks for your PR! Is it possible to move your Javascript functions outside of the ng-flow-standalone.js file which gets updated with a new version from time to time?

@JonathanTreffler
Copy link
Collaborator Author

I added a counter that shows the number of finished chunks to the file size hover overlay (from the html title attribute).

It looks like this:
Screenshot_20190505_164739

@JonathanTreffler
Copy link
Collaborator Author

Thanks for your PR! Is it possible to move your Javascript functions outside of the ng-flow-standalone.js file which gets updated with a new version from time to time?

I added 2 functions:

  • getFilesCount() (function of the flow prototype)
  • completeChunks() (function of the flowFile prototype)

I am a noob at angularjs but i dont understand how and why to move a function of an object / prototype to an other file.
those functions are not global.

e-alfred added a commit to e-alfred/ng-flow that referenced this pull request May 14, 2019
@e-alfred
Add a overall files count and uploaded chunk function
0fa10c4 
I am the maintainer of the Flowupload app for Nextcloud which uses ng-flow extensively. Recently @TessyPowder added two functions to ng-flow which adds a counter for all files and a function to count already uploaded chunks. I would like to bring these changes to upstream so other projects can use them as well and so they are in the right place.

The original PR on my repository can be found here:

e-alfred/flowupload#57
@e-alfred e-alfred mentioned this pull request May 14, 2019
Open
@e-alfred
Copy link
Owner

Hello,

I proposed your changes to the upstream project (ng-flow) so they can be integrated into the official ng-flow-standalone.js library. Here is the link:

flowjs/ng-flow#353

This will make maintaining and upgrading these libraries easier because they wouldn't depend on changes that would have to be made everytime the library gets updated.

@JonathanTreffler JonathanTreffler mentioned this pull request May 14, 2019
Closed
@e-alfred e-alfred merged commit 212bda7 into e-alfred:master May 17, 2019
@e-alfred
Copy link
Owner

e-alfred commented May 17, 2019 •
edited by JonathanTreffler
Loading

I merge this, hopefully it will be included upstream in the future. Thanks @JonathanTreffler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanTreffler @e-alfred