Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to work in postgres #196

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vitormattos
Copy link

In PostgreSQL columns with double quote are interpreted literally.

I used Nextcloud 20.0.4, and when setup finished, all columns where created in lowercase.

To resolve this problem, I changed all columns to syntax without double quotes.

The WhichDownloader property was being used incorrectly when it was to be CURL. Adjustments were made to avoid errors.

I changed some places that were giving error for accessing array keys that didn't exist.

@weeman1337 weeman1337 self-requested a review October 10, 2021 17:21
@weeman1337
Copy link
Contributor

Hi @vitormattos thanks for the pull request. Could you please solve the conflict?

I could then check if it still works on MySQL / SQLite databases. There are now some keywords in use like for example TIMESTAMP. The best would be quoting the identifiers database dependent.

@vitormattos
Copy link
Author

I could then check if it still works on MySQL / SQLite databases. There are now some keywords in use like for example TIMESTAMP. The best would be quoting the identifiers database dependent.

I believe the best way will be use QueryBuilder for all queryies but it will be a big refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants