Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing prevTrip, displaying trip date on trip item #904

Conversation

sebastianbarry
Copy link
Contributor

infinite_scroll_list.js

infinite_scroll_list.html

  • Commenting out the hr-lines style that displays the trip date above the list of trips

trip_list_item.html

  • Displaying the date from within the trip item
  • Removed the previous styling that was unnecessary for this div since it previously didn't have any text inside it

infinite_scroll_list.js
- Removing prevTrip, because this was causing issues in the regression e-mission/e-mission-docs#823 and we will replace it with another way to display the date to come

infinite_scroll_list.html
- Commenting out the hr-lines style that displays the trip date above the list of trips

trip_list_item.html
- Displaying the date from within the trip item
- Removed the previous styling that was unnecessary for this div since it previously didn't have any text inside it
@shankari
Copy link
Contributor

shankari commented Nov 2, 2022

superceded by #906

@shankari shankari closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants