Improving Trip Segmentation #953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced loop for DB query with bulk_write method
Moving transition_Df and motion_df calls upstream in trip_segmentation to improve performance.
|
Tested. Will fail. |
|
@humbleOldSage can ypu:
This will let me chose which of the improvements to merge. Making server changes can introduce code churn, and I am not convinced that the invalidating raw entry change (which involves a change to the timeseries interface) is worth it. |
|
Sure. I'll create two separate PRs for these two changes. |
|
@humbleOldSage if this has been replaced by other calls, can you please close this PR? |
|
Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducing DB calls. Using more in memory operations.