Adding scripts used for my analysis #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankari
requested changes
Aug 11, 2022
viz_scripts/Ebike Usage Trends.ipynb
Outdated
Comment on lines
1409
to
1444
| " if user['month'+str(i)][j].start_local_dt_month.iloc[0]==12 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2020:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'December 2020']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==1 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'January 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==2 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'February 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==3 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'March 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==4 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'April 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==5 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'May 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==6 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'June 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==7 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'July 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==8 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'August 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==9 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'September 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==10 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'October 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==11 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'November 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==12 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2021:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'December 2021']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==1 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2022:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'January 2022']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==2 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2022:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'February 2022']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==3 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2022:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'March 2022']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==4 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2022:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'April 2022']=percent\n", | ||
| " elif user['month'+str(i)][j].start_local_dt_month.iloc[0]==5 and user['month'+str(i)][j].start_local_dt_year.iloc[0]==2022:\n", | ||
| " timeline.at[str(user['month'+str(i)][j].Income.iloc[0]),'May 2022']=percent\n", |
There was a problem hiding this comment.
This is extremely repetitive and will not scale. What if I want to run the same script next summer?
Isn't there an easier way to do this using a loop or something?
Comment on lines
+1455
to
+1459
| " for i in range(len(timeline)-1):\n", | ||
| " sns.lineplot(ax=ax,x=timeline.loc[timeline.index[-1]],y=timeline.iloc[i],data=timeline,marker='o')\n", | ||
| " plt.legend(bbox_to_anchor=(1, 1), loc='upper left', labels = timeline.index)\n", | ||
| " plt.show\n", | ||
| "\n", |
There was a problem hiding this comment.
Also, as we indicated, this doesn't really show any significant differences. Did you try the boxplot approach?
There was a problem hiding this comment.
you can look at #47
for boxplot examples
viz_scripts/Ebike Usage Trends.ipynb
Outdated
| "outputs": [], | ||
| "source": [ | ||
| "file_suffix = scaffolding.get_file_suffix(year, month, program)\n", | ||
| "quality_text = scaffolding.get_quality_text(participant_ct_df, participant)" |
There was a problem hiding this comment.
The quality text is still based on participant_ct_df, so I am not sure how it is fixed...
viz_scripts/Ebike Usage Trends.ipynb
Outdated
Comment on lines
1578
to
1582
| " for i in range(len(timeline)-1):\n", | ||
| " sns.lineplot(ax=ax,x=timeline.loc[timeline.index[-1]],y=timeline.iloc[i],data=timeline,marker='o')\n", | ||
| " plt.legend(bbox_to_anchor=(1, 1), loc='upper left', labels = timeline.index)\n", | ||
| " plt.show\n", | ||
| "\n", |
There was a problem hiding this comment.
The output for this is super messy and is essentially unreadable. Please check with Bingrong on what story this is telling and how to represent it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I removed outputs this time