For autogen=true, show join links / QR codes instead of generating OPcodes
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-mission/e-mission-docs#1076 OPcodes are meant to be used by only one person. For autogen studies, generating them on the join page introduces the possibility that users will misinterpret the instructions and share OPcodes with others. Instead, we can provide a "join" link which takes users to the app and generates an OPcode there. The "join" link includes the same parameters that the join page can have: study_config, sub_group, and tester. If viewing the join page on a mobile device, we provide the join link as a button which directly links to the app (assuming it has been installed per instructions). Otherwise, we provide the link as a QR code. We also provide the link as text to easily copy and paste. Several of the functions related to token generation are no longer needed here and are being moved to e-mission-phone. a derivative of _getStudyName is still kept, called getStudyNameFromUrl, consistent with what e-mission-phone will have.
-to reflect changes of OPcode generation now happening on the phone; make instructions clearer -to fix gaps between inline elements, like unintended spaces before period in "participant guidelines ."
English matches the strings in index.html. Used Google translate for Spanish and Lao; sanity-checked to the best of my ability but cannot guarantee the accuracy of the translations
JGreenlee
changed the title
autogen=true, show join links / QR codes instead of generating OPcodes
"emission://" was used for the purpose of testing, but on production we want this to use nrelopenpath://
If the app is installed and the join button is clicked, the user will be taken directly to the app before they see this alert. If they do not have the app installed, they will see this alert prompting them to follow the instructions above tested on Android and iOS with app installed and not installed
JGreenlee
force-pushed
the
onboarding-redesign-oct2024
branch
from
0f10a2c
to
16b0263
Compare
Result of clicking "JOIN"iOS Safari: If NREL OpenPATH is installed: 
If NREL OpenPATH is not installed: 
Tested this on Chrome Android as well. If OpenPATH is installed, it opens immediately (there is no "Open in ..." popup) If OpenPATH is not installed, the "If the app does not automatically ..." popup shows immediately It's a little odd in Firefox, but you can still click past the popup to access the banner at the bottom 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old join page:
New join page (viewed on desktop/laptop/tablet)
If the app is installed on the user's phone and they scan the QR code, either from within the app or their phone's camera, the app will launch, generate an OPcode, and begin onboarding for the study
New join page (viewed on phone):
If the app is installed, this button will launch it, generate an OPcode, and begin onboarding for the study