Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing deprecated A from scipy, in1d from numpy and fix chained indexing pandas #2515

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

quant12345
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.56%. Comparing base (8009cb5) to head (afba1b2).

Files with missing lines Patch % Lines
pandapower/runpm.py 0.00% 2 Missing ⚠️
pandapower/converter/pandamodels/from_pm.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2515      +/-   ##
===========================================
- Coverage    75.56%   75.56%   -0.01%     
===========================================
  Files          284      284              
  Lines        33817    33817              
===========================================
- Hits         25555    25554       -1     
- Misses        8262     8263       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quant12345 quant12345 changed the title replacing deprecated A from scipy replacing deprecated A from scipy, in1d from numpy and fix chained indexing pandas Jan 23, 2025
@quant12345
Copy link
Contributor Author

I don't understand the Codecov / codecov/patch errors, I didn't add the lines (I changed these lines). This is what I get:

pandapower/converter/pandamodels/from_pm.py#L74
Added line #L74 was not covered by tests

pandapower/runpm.py#L358
Added line #L358 was not covered by tests

pandapower/runpm.py#L385
Added line #L385 was not covered by tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant