Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tree 1c #49

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Feature/tree 1c #49

wants to merge 5 commits into from

Conversation

fishca
Copy link

@fishca fishca commented Nov 9, 2017

Исправляю свой недосмотр

@fishca
Copy link
Author

fishca commented Nov 9, 2017

вот жеж std::max/min на винде и на линухах это совсем не одно и то же :(

@dmpas
Copy link
Collaborator

dmpas commented Nov 9, 2017

https://travis-ci.org/dmpas/v8unpack/builds/299566458

таки не собирается с std::max, потому в своё время остался на MAX.

@fishca
Copy link
Author

fishca commented Nov 9, 2017

надо поколдовать на эту тему...

@dmpas
Copy link
Collaborator

dmpas commented Nov 15, 2017

@fishca как успехи? ты спрашивай, если что. В тул1сд на те же костыли натыкались.

@ava57r
Copy link
Member

ava57r commented Dec 2, 2017

std::min and std::max шаблонные. Оба параметра метода должны быть одного типа.
Для шаблонной функции неявное приведение типа не работает.
в тул1цд сделано так

curlen = std::min(static_cast<uint64_t>(DEFAULT_PAGE_SIZE - curoffblock), _length);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants