Matching format specifies type to argument type to eliminate compile … #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greensky00
reviewed
Jul 18, 2024
src/raft_server.cxx
Outdated
| @@ -1151,7 +1151,7 @@ void raft_server::check_leadership_transfer() { | |||
| if (peer_elem->get_matched_idx() + params->stale_log_gap_ < | |||
| cur_commit_idx) { | |||
| // This peer is lagging behind. | |||
| p_tr("peer %d is lagging behind, %lu < %lu", | |||
| p_tr("peer %d is lagging behind, %llu < %llu", | |||
There was a problem hiding this comment.
Please use PRIu64. This symbol is different according to the platform.
There was a problem hiding this comment.
There are many %lu, %llu, %d use case across the whole repo, but I am only fixing this line because it has warning during compile.
I fixed it to use PRIu64.
There was a problem hiding this comment.
%d probably be ok, but 64-bit integers should be replaced. The whole project was re-visited a couple of years ago, but if there are still missing ones, we need to fix them.
There was a problem hiding this comment.
~ grep -rn "%l" .
./fix_format.hxx:20: replace_all(format_string, "%ld", "%" PRId64); \
./fix_format.hxx:21: replace_all(format_string, "%lu", "%" PRIu64); \
./asio_service.cxx:336: "due to error %d, %s, ref count %ld",
We don't need to care about ./fix_format.hxx, the %ld in ./asio_service.cxx is correct, I think that is all the case.
greensky00
reviewed
Jul 18, 2024
src/raft_server.cxx
Outdated
| @@ -1160,7 +1160,7 @@ void raft_server::check_leadership_transfer() { | |||
| uint64_t last_resp_ms = peer_elem->get_resp_timer_us() / 1000; | |||
| if (last_resp_ms > election_lower) { | |||
| // This replica is not responding. | |||
| p_tr("peer %d is not responding, %lu ms ago", | |||
| p_tr("peer %d is not responding, %llu ms ago", | |||
There was a problem hiding this comment.
Please replace this one too.
greensky00
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…warnings
format specifies type 'unsigned long' but the argument has type 'ulong' (aka 'unsigned long long').