Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): update focus outline and offset #2449

Merged
merged 3 commits into from
Sep 20, 2024
Merged

fix(button): update focus outline and offset #2449

merged 3 commits into from
Sep 20, 2024

Conversation

saiponnada
Copy link
Contributor

@saiponnada saiponnada commented Sep 18, 2024

Fixes #2075

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • For button:btn & a.fake-btn:focus added outline for :focus-visible pseudo selector

Notes

  • Outline color need to be changed consistently across all buttons and other interactive elements. Update Buttons to Design Spec  #2421
  • Another issue noticed is the focus overlapping on skin docs site when multiple buttons are adjacent to each other.

Screenshots

image image

Primary Button
image
image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 12f9923

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Im a bit worried about the overlap, but its probably fine for now.

@saiponnada saiponnada merged commit b2dfcf1 into 18.3.0 Sep 20, 2024
@saiponnada saiponnada deleted the btn-outline branch September 20, 2024 17:47
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants