This repository has been archived by the owner on Mar 21, 2018. It is now read-only.
Run commands in clean bundler env #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execute all Git commands in a `Bundler.clean_env` to ensure we're using the right versions of everything. Fixes an issue where previously a `rain` deploy could not be combined with any "Git hook"-creating plugins, such as `git-tracker`, or else the commit would fail due to the improper Ruby being used. Thanks to @stevenharman and @alindeman for showing us this awesome little Bundler trick, which helps us mitigate this issue and any future problems that may be encountered in the course of Rain's use with other Git plugins.
We're just wrapping the existing execution command in a with_clean_env to mitigate this issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, Rain will fail to commit its changes to
config/versions.ymland cause mass havoc in deployment. This was usually due to a rogue Git plugin that was using an outdated (system) version of Ruby and not included in the Gemfile (because it's not an application-level dependency). It has been fixed by wrapping all GitTools commands within aBundler.with_clean_envblock, which will ensure the proper Ruby and versions of each gem are loaded in as Rain is deploying.Special thanks to @stevenharman who introduced me to this technique and @alindeman for expanding on it and providing a few extra options for running commands in a Bundler env. You guys rock!