Empty XTSAN tests list #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanlofer-eprosima
temporarily deployed
to
codecov
GitHub Actions
Inactive
|
Tests are failing because only ddsrecorder packages are compiled with TSAN, while it should be every single package to avoid false positives like it is the case here. EDIT: |
juanlofer-eprosima
force-pushed
the
feature/remove-xtsan
branch
from
fce7789
to
0d0cef1
Compare
juanlofer-eprosima
temporarily deployed
to
codecov
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
- Coverage 24.02% 24.00% -0.02%
==========================================
Files 55 55
Lines 4008 4007 -1
Branches 2070 2070
==========================================
- Hits 963 962 -1
- Misses 2348 2353 +5
+ Partials 697 692 -5 ☔ View full report in Codecov by Sentry. |
juanlofer-eprosima
temporarily deployed
to
codecov
GitHub Actions
Inactive
Signed-off-by: Juan Lopez Fernandez <[email protected]>
juanlofer-eprosima
force-pushed
the
feature/remove-xtsan
branch
from
0d0cef1
to
a97921c
Compare
juanlofer-eprosima
temporarily deployed
to
codecov
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to eProsima/eProsima-CI#77 , almost every test using Fast-DDS was reporting multiple TSAN warnings that were in fact false positives. For this reason these tests were categorized as flaky when running the TSAN action, but after the update in eProsima-CI they should no longer fail.