Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generating code when the dependency is in another directory [19082] #198

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Fix generating code when the dependency is in another directory [19082] #198

merged 6 commits into from
Jul 5, 2023

Conversation

richiware
Copy link
Member

@richiware richiware commented Jun 30, 2023 •
edited
Loading

Depends on:

For a case where an IDL file includes another one in another directory, the generation fails.

#include "helper/other.idl"
...

richiware and others added 6 commits June 30, 2023 09:25
@richiware
Refs #19080. Able to work with idl in directories
856efad 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19080. Improve
3157820 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19080. Fix tests
c458f31 
Signed-off-by: Ricardo González Moreno <[email protected]>
@adriancampo @richiware
Improved CMake template.
45a1d3f 
Signed-off-by: AdrianCampo <[email protected]>
@richiware
Refs #19080. Update submodule
bc74a52 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19080. Update submodule
b73b8c5 
Signed-off-by: Ricardo González Moreno <[email protected]>
adriancampo
adriancampo approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@adriancampo adriancampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit 7951e14 into master Jul 5, 2023
@richiware richiware deleted the feature/19080 branch July 5, 2023 11:22
@richiware richiware changed the title Fix generating code when the dependency is in another directory Fix generating code when the dependency is in another directory [19082] Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriancampo adriancampo adriancampo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @adriancampo