Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed usage of const as literals #248

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Fixed usage of const as literals #248

merged 4 commits into from
Oct 9, 2023

Conversation

richiware
Copy link
Member

JLBuenoLopez
JLBuenoLopez reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nitpick

src/main/java/com/eprosima/fastcdr/idl/templates/TypesHeader.stg Outdated Show resolved Hide resolved
@richiware
Refs #13731. Apply suggestion
fe0e0e4 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware merged commit 7df0be7 into master Oct 9, 2023
5 checks passed
@richiware richiware deleted the bugfix/const-literals branch October 9, 2023 14:05
@JLBuenoLopez JLBuenoLopez mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @JLBuenoLopez