Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21686] Use different typename for collections of TK_UINT8 and TK_BYTE #400

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Sep 17, 2024

Description

Currently a collection of TK_UINT8 and a collection of TK_BYTE will be registered by the same typename. But are different types. This PR fixes it.

Depends on:

Contributor Checklist

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Use different typename for collections of TK_UINT8 and TK_BYTE [21686] Use different typename for collections of TK_UINT8 and TK_BYTE Sep 17, 2024
@MiguelCompany MiguelCompany added this to the v4.0.2 milestone Sep 17, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 17, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss a regression test here

Signed-off-by: Ricardo González Moreno <[email protected]>
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Sep 23, 2024
@richiware richiware merged commit f61a07e into master Sep 24, 2024
4 checks passed
@richiware richiware deleted the bugfix/20878 branch September 24, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants