-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21416] Enhance Fast DDS docs with a FAQs section covering every subsection #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciaEchevarria99
requested changes
Sep 18, 2024
LuciaEchevarria99
requested changes
Sep 18, 2024
LuciaEchevarria99
requested changes
Sep 20, 2024
depink5
force-pushed
the
feature/faq
branch
from
September 20, 2024 09:29
493700d
to
a3ab4b2
Compare
LuciaEchevarria99
requested changes
Sep 24, 2024
depink5
force-pushed
the
feature/faq
branch
from
September 24, 2024 14:25
a3ab4b2
to
a2a4405
Compare
* Refs #21416: Add FAQs section Signed-off-by: Denisa <[email protected]> * FAQ section Signed-off-by: Denisa <[email protected]> * Refs #21416: Frequently Asked Questions-add review comments Signed-off-by: Denisa <[email protected]> --------- Signed-off-by: Denisa <[email protected]> Co-authored-by: Denisa <[email protected]>
* Refs #21416: Add FAQs section Signed-off-by: Denisa <[email protected]> * FAQ section Signed-off-by: Denisa <[email protected]> * Refs #21416: Frequently Asked Questions-add review comments Signed-off-by: Denisa <[email protected]> --------- Signed-off-by: Denisa <[email protected]> Co-authored-by: Denisa <[email protected]>
Signed-off-by: Carlosespicur <[email protected]>
LuciaEchevarria99
previously approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JesusPoderoso
requested changes
Sep 24, 2024
Signed-off-by: Denisa <[email protected]>
depink5
force-pushed
the
feature/faq
branch
from
September 25, 2024 07:13
a2a4405
to
d69ce11
Compare
JesusPoderoso
requested changes
Sep 25, 2024
Signed-off-by: Denisa <[email protected]>
JesusPoderoso
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good job @depink5!! 🏅
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a Frequently Asked Questions (FAQs) section to FastDDS Documentation.
Contributor Checklist
Reviewer Checklist