Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20509] Update repository for Fast DDS 3.0.0 compatibility #86

Merged
merged 10 commits into from
Sep 16, 2024
Merged

[20509] Update repository for Fast DDS 3.0.0 compatibility #86

merged 10 commits into from
Sep 16, 2024

Conversation

LuciaEchevarria99
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 commented May 20, 2024 •
edited by juanlofer-eprosima
Loading

@Tempate Tempate changed the title Update repository for Fast DDS 3.0.0 compatibility [20509] Update repository for Fast DDS 3.0.0 compatibility Jul 19, 2024
@LuciaEchevarria99
Remove tool_show_topic_dds test
c2e07b7 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Apply suggested changes
373bd9f 
Signed-off-by: Lucia Echevarria <[email protected]>
juanlofer-eprosima
juanlofer-eprosima requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update gtest version to 1.12 , and remove note about publish-types in monitoring configuration sections.

fastddsspy_participants/src/cpp/model/DataStreamer.cpp Outdated Show resolved Hide resolved
@LuciaEchevarria99
Update log macro and fix XTSAN list
45c60d0 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Update documentation
d8a87ac 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Uncrustify
2463e94 
Signed-off-by: Lucia Echevarria <[email protected]>
juanlofer-eprosima
juanlofer-eprosima approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passing -> https://github.com/eProsima/Fast-DDS-spy/actions/runs/10883479273

@rsanchez15 rsanchez15 merged commit f38df04 into main Sep 16, 2024
4 of 19 checks passed
@rsanchez15 rsanchez15 deleted the integration/bump-3.0.0 branch September 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuciaEchevarria99 @juanlofer-eprosima @rsanchez15