Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18721] Typelookup service tests #3597

Closed
wants to merge 14 commits into from
Closed

[18721] Typelookup service tests #3597

wants to merge 14 commits into from

Conversation

JLBuenoLopez
Copy link
Contributor

Description

This PR includes tests for the TypeLookup Service.
Only commits referencing task 18721 should be reviewed (it would be nice to have the intermediate branch rebased).

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JLBuenoLopez JLBuenoLopez added the no-test Skip CI tests if PR marked with this label label Jun 15, 2023
@JLBuenoLopez JLBuenoLopez added this to the v2.12.0 milestone Jun 15, 2023
@JLBuenoLopez
Copy link
Contributor Author

Linters fail in code generated by Fast DDS-Gen

@JLBuenoLopez JLBuenoLopez modified the milestones: v2.12.0, v2.13.0 Sep 13, 2023
@JLBuenoLopez
Refs #18721: typelookup service builtin endpoints configuration unit …
a16c948 
…testing

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #18721: improve doxygen documentation
785782a 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #18721: improve and extend ParticipantTests related to TypeLooku…
43edca9 
…pService

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #18721: add unit tests analyzing TypeLookup Service requests
47f945b 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #18721: move TypeLookup service tests from dynamic tests folder …
352bbd8 
…to xtypes folder

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #18721: add TypeLookup Service test types
3516d64 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #18721: use specific test type
7681965 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #18721: refactor test infrastructure and include get_type_depend…
20dbe8f 
…encies operation test

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #18721: include expected tests
6dfdc1c 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #18721: add get types operation tests
c52fbcd 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #18721: comment pending tests
e23ec54 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #18721: linters
31b2d71 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Copy link
Contributor Author

@richiprosima please test this

@EduPonz EduPonz modified the milestones: v2.13.0, v3.0.0 Nov 23, 2023
@JLBuenoLopez
Copy link
Contributor Author

Close in favor of #4339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JLBuenoLopez @EduPonz