Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17513] Add nightly Ubuntu Github CI #4109

Merged
merged 7 commits into from
Feb 29, 2024
Merged

[17513] Add nightly Ubuntu Github CI #4109

merged 7 commits into from
Feb 29, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Dec 6, 2023

Description

This PR adds:

  • A reusable workflow for Ubuntu CI
  • A nightly workflow for Ubuntu CI in 22.04

Should be merged after:

TODO:

  • Drop testing commit that enables testing on push to branch

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz
Copy link
Author

EduPonz commented Dec 8, 2023

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Copy link
Contributor

mergify bot commented Dec 8, 2023

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

@EduPonz EduPonz modified the milestones: v2.13.0, v2.13.1 Dec 19, 2023
@MiguelCompany MiguelCompany modified the milestones: v2.13.1, v2.13.2 Dec 22, 2023
@EduPonz EduPonz modified the milestones: v2.13.2, v2.13.3 Feb 1, 2024
@EduPonz EduPonz force-pushed the ci/gh_mac_ci branch 6 times, most recently from 9da466e to 93aa937 Compare February 17, 2024 08:38
@EduPonz EduPonz modified the milestones: v2.13.3, v2.14.0 Feb 18, 2024
Base automatically changed from ci/gh_mac_ci to master February 20, 2024 07:17
@EduPonz EduPonz force-pushed the ci/gh_ubuntu_ci branch 3 times, most recently from 29e6cde to 61eadaf Compare February 24, 2024 15:02
@JesusPoderoso
Copy link
Contributor

@Mergifyio backport 2.13.x

Copy link
Contributor

mergify bot commented Feb 25, 2024

backport 2.13.x

✅ Backports have been created

@JesusPoderoso
Copy link
Contributor

This test BlackboxTests_DDS_PIM.Discovery.ServerClientEnvironmentSetUpDNS seems to fail in both Ubuntu, Mac and sanitizer cases

@EduPonz
Copy link
Author

EduPonz commented Feb 26, 2024

This test BlackboxTests_DDS_PIM.Discovery.ServerClientEnvironmentSetUpDNS seems to fail in both Ubuntu, Mac and sanitizer cases

It makes sense that it fails, as the DNS is not configured. What I don't understand yet is why it runs in the first place, specially given:

set(dns_filter "-*ServerClientEnvironmentSetUpDNS*")

@EduPonz EduPonz added the to-do label Feb 26, 2024
@EduPonz EduPonz added needs-review PR that is ready to be reviewed and removed to-do labels Feb 28, 2024
JesusPoderoso
JesusPoderoso previously approved these changes Feb 29, 2024
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRGTM! 🥹

@EduPonz EduPonz added skip-ci Automatically pass CI and removed needs-review PR that is ready to be reviewed labels Feb 29, 2024
@EduPonz EduPonz changed the title [17513] Add Ubuntu Github CI [17513] Add nightly Ubuntu Github CI Feb 29, 2024
@EduPonz EduPonz merged commit b656a17 into master Feb 29, 2024
9 checks passed
@EduPonz EduPonz deleted the ci/gh_ubuntu_ci branch February 29, 2024 10:10
mergify bot pushed a commit that referenced this pull request Feb 29, 2024
* Refs #17513: Add github actions Ubuntu CI

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Do not update /etc/hosts as we don't have permissions

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Correctly name job

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Install python packages without sudo

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Only run Ubuntu CI nightly, and do it in 22.04

Signed-off-by: EduPonz <[email protected]>

* DROP: Add push event for testing the workflow

Signed-off-by: EduPonz <[email protected]>

* Revert "DROP: Add push event for testing the workflow"

This reverts commit 5b27c03.

---------

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit b656a17)
mergify bot pushed a commit that referenced this pull request Feb 29, 2024
* Refs #17513: Add github actions Ubuntu CI

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Do not update /etc/hosts as we don't have permissions

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Correctly name job

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Install python packages without sudo

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Only run Ubuntu CI nightly, and do it in 22.04

Signed-off-by: EduPonz <[email protected]>

* DROP: Add push event for testing the workflow

Signed-off-by: EduPonz <[email protected]>

* Revert "DROP: Add push event for testing the workflow"

This reverts commit 5b27c03.

---------

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit b656a17)
mergify bot pushed a commit that referenced this pull request Feb 29, 2024
* Refs #17513: Add github actions Ubuntu CI

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Do not update /etc/hosts as we don't have permissions

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Correctly name job

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Install python packages without sudo

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Only run Ubuntu CI nightly, and do it in 22.04

Signed-off-by: EduPonz <[email protected]>

* DROP: Add push event for testing the workflow

Signed-off-by: EduPonz <[email protected]>

* Revert "DROP: Add push event for testing the workflow"

This reverts commit 5b27c03.

---------

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit b656a17)
mergify bot pushed a commit that referenced this pull request Feb 29, 2024
* Refs #17513: Add github actions Ubuntu CI

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Do not update /etc/hosts as we don't have permissions

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Correctly name job

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Install python packages without sudo

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Only run Ubuntu CI nightly, and do it in 22.04

Signed-off-by: EduPonz <[email protected]>

* DROP: Add push event for testing the workflow

Signed-off-by: EduPonz <[email protected]>

* Revert "DROP: Add push event for testing the workflow"

This reverts commit 5b27c03.

---------

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit b656a17)
mergify bot pushed a commit that referenced this pull request Feb 29, 2024
* Refs #17513: Add github actions Ubuntu CI

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Do not update /etc/hosts as we don't have permissions

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Correctly name job

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Install python packages without sudo

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Only run Ubuntu CI nightly, and do it in 22.04

Signed-off-by: EduPonz <[email protected]>

* DROP: Add push event for testing the workflow

Signed-off-by: EduPonz <[email protected]>

* Revert "DROP: Add push event for testing the workflow"

This reverts commit 5b27c03.

---------

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit b656a17)
MiguelCompany pushed a commit that referenced this pull request Mar 6, 2024
* Add nightly Ubuntu Github CI (#4109)

* Refs #17513: Add github actions Ubuntu CI

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Do not update /etc/hosts as we don't have permissions

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Correctly name job

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Install python packages without sudo

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Only run Ubuntu CI nightly, and do it in 22.04

Signed-off-by: EduPonz <[email protected]>

* DROP: Add push event for testing the workflow

Signed-off-by: EduPonz <[email protected]>

* Revert "DROP: Add push event for testing the workflow"

This reverts commit 5b27c03.

---------

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit b656a17)

* Refs #20542: Refactor nightly workflow to be wd (workflow dispatch) only

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #205442: Apply concurrency group suggestion

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
cferreiragonz pushed a commit that referenced this pull request Mar 11, 2024
* Add nightly Ubuntu Github CI (#4109)

* Refs #17513: Add github actions Ubuntu CI

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Do not update /etc/hosts as we don't have permissions

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Correctly name job

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Install python packages without sudo

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Only run Ubuntu CI nightly, and do it in 22.04

Signed-off-by: EduPonz <[email protected]>

* DROP: Add push event for testing the workflow

Signed-off-by: EduPonz <[email protected]>

* Revert "DROP: Add push event for testing the workflow"

This reverts commit 5b27c03.

---------

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit b656a17)

* Refs #20542: Refactor nightly workflow to be wd (workflow dispatch) only

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #205442: Apply concurrency group suggestion

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
EduPonz added a commit that referenced this pull request Mar 13, 2024
* Refs #20542: Refactor nightly workflow to be wd (workflow dispatch) only

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Apply concurrency group suggestion

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Set ubuntu:20.04 as OS

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20542: Use CMake 3.16.3

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
Co-authored-by: EduPonz <[email protected]>
EduPonz added a commit that referenced this pull request Mar 13, 2024
* Add nightly Ubuntu Github CI (#4109)

* Refs #17513: Add github actions Ubuntu CI

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Do not update /etc/hosts as we don't have permissions

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Correctly name job

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Install python packages without sudo

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Only run Ubuntu CI nightly, and do it in 22.04

Signed-off-by: EduPonz <[email protected]>

* DROP: Add push event for testing the workflow

Signed-off-by: EduPonz <[email protected]>

* Revert "DROP: Add push event for testing the workflow"

This reverts commit 5b27c03.

---------

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit b656a17)

* Change default branch to 2.12.x

Signed-off-by: elianalf <[email protected]>

* Refs #20542: Refactor nightly workflow to be wd (workflow dispatch) only

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #205442: Apply concurrency group suggestion

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20542: Remove nightly job

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Co-authored-by: elianalf <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
EduPonz added a commit that referenced this pull request Mar 13, 2024
* Add nightly Ubuntu Github CI (#4109)

* Refs #17513: Add github actions Ubuntu CI

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Do not update /etc/hosts as we don't have permissions

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Correctly name job

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Install python packages without sudo

Signed-off-by: EduPonz <[email protected]>

* Refs #17513: Only run Ubuntu CI nightly, and do it in 22.04

Signed-off-by: EduPonz <[email protected]>

* DROP: Add push event for testing the workflow

Signed-off-by: EduPonz <[email protected]>

* Revert "DROP: Add push event for testing the workflow"

This reverts commit 5b27c03.

---------

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit b656a17)

* Refs #20542: Refactor nightly workflow to be wd (workflow dispatch) only

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #205442: Apply concurrency group suggestion

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants