Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20786] Build ShapesDemo on Ubuntu Github CI #4678

Merged
merged 3 commits into from
Apr 17, 2024
Merged

[20786] Build ShapesDemo on Ubuntu Github CI #4678

merged 3 commits into from
Apr 17, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Apr 10, 2024 •
edited by JesusPoderoso
Loading

Description

This PR adds Fast DDS Shapes Demo to the packages built in Ubuntu Gibthub CI so we have certainty that changes in Fast DDS do not broke Shapes Demo compilation.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v2.14.1 milestone Apr 10, 2024
@EduPonz EduPonz marked this pull request as ready for review April 10, 2024 05:26
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 10, 2024
JesusPoderoso

This comment was marked as outdated.

Sign in to view

@EduPonz EduPonz force-pushed the ci/build_shapes_demo_ubuntu_ci branch from 31f45ea to 2371abc Compare April 16, 2024 12:50
JesusPoderoso

This comment was marked as outdated.

Sign in to view

JesusPoderoso
JesusPoderoso requested changes Apr 16, 2024
View reviewed changes
.github/workflows/config/ci.meta Outdated Show resolved Hide resolved
@EduPonz EduPonz added the skip-ci Automatically pass CI label Apr 17, 2024
@EduPonz EduPonz added no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI labels Apr 17, 2024
@EduPonz EduPonz requested review from JesusPoderoso and removed request for JesusPoderoso April 17, 2024 04:48
JesusPoderoso
JesusPoderoso approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😁

@EduPonz
Copy link
Author

EduPonz commented Apr 17, 2024

@Mergifyio backport 2.13.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024 •
edited
Loading

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

@EduPonz EduPonz merged commit a35c846 into master Apr 17, 2024
10 of 14 checks passed
@EduPonz EduPonz deleted the ci/build_shapes_demo_ubuntu_ci branch April 17, 2024 05:52
mergify bot pushed a commit that referenced this pull request Apr 17, 2024
@EduPonz @mergify
Build ShapesDemo on Ubuntu Github CI (#4678)
14bc91a 
* Refs #20786: Build ShapesDemo on Ubuntu Github CI

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Install Qt

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Remove unnecessary entry in ci.meta

Signed-off-by: eduponz <[email protected]>

---------

Signed-off-by: eduponz <[email protected]>
(cherry picked from commit a35c846)
@mergify mergify bot mentioned this pull request Apr 17, 2024
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Apr 17, 2024
@EduPonz @mergify
Build ShapesDemo on Ubuntu Github CI (#4678)
808abfd 
* Refs #20786: Build ShapesDemo on Ubuntu Github CI

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Install Qt

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Remove unnecessary entry in ci.meta

Signed-off-by: eduponz <[email protected]>

---------

Signed-off-by: eduponz <[email protected]>
(cherry picked from commit a35c846)
mergify bot pushed a commit that referenced this pull request Apr 17, 2024
@EduPonz @mergify
Build ShapesDemo on Ubuntu Github CI (#4678)
f095519 
* Refs #20786: Build ShapesDemo on Ubuntu Github CI

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Install Qt

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Remove unnecessary entry in ci.meta

Signed-off-by: eduponz <[email protected]>

---------

Signed-off-by: eduponz <[email protected]>
(cherry picked from commit a35c846)
This was referenced Apr 17, 2024
Merged
Merged
JesusPoderoso pushed a commit that referenced this pull request Apr 17, 2024
@EduPonz @JesusPoderoso
Build ShapesDemo on Ubuntu Github CI (#4678)
58f7af4 
* Refs #20786: Build ShapesDemo on Ubuntu Github CI

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Install Qt

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Remove unnecessary entry in ci.meta

Signed-off-by: eduponz <[email protected]>

---------

Signed-off-by: eduponz <[email protected]>
(cherry picked from commit a35c846)
JesusPoderoso pushed a commit that referenced this pull request Apr 18, 2024
@EduPonz @JesusPoderoso
Build ShapesDemo on Ubuntu Github CI (#4678)
56e4aa5 
* Refs #20786: Build ShapesDemo on Ubuntu Github CI

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Install Qt

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Remove unnecessary entry in ci.meta

Signed-off-by: eduponz <[email protected]>

---------

Signed-off-by: eduponz <[email protected]>
(cherry picked from commit a35c846)
EduPonz added a commit that referenced this pull request Apr 18, 2024
@mergify @EduPonz
Build ShapesDemo on Ubuntu Github CI (#4678) (#4688)
62441c4 
* Refs #20786: Build ShapesDemo on Ubuntu Github CI

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Install Qt

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Remove unnecessary entry in ci.meta

Signed-off-by: eduponz <[email protected]>

---------

Signed-off-by: eduponz <[email protected]>
(cherry picked from commit a35c846)

Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
EduPonz added a commit that referenced this pull request Apr 18, 2024
@mergify @EduPonz
Build ShapesDemo on Ubuntu Github CI (#4678) (#4690)
620a935 
* Refs #20786: Build ShapesDemo on Ubuntu Github CI

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Install Qt

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Remove unnecessary entry in ci.meta

Signed-off-by: eduponz <[email protected]>

---------

Signed-off-by: eduponz <[email protected]>
(cherry picked from commit a35c846)

Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Apr 19, 2024
@mergify @EduPonz
Build ShapesDemo on Ubuntu Github CI (#4678) (#4689)
19ff11b 
* Refs #20786: Build ShapesDemo on Ubuntu Github CI

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Install Qt

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Remove unnecessary entry in ci.meta

Signed-off-by: eduponz <[email protected]>

---------

Signed-off-by: eduponz <[email protected]>
(cherry picked from commit a35c846)

Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @JesusPoderoso