Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20945] Fix SecurityTest unittests memory error #4750

Merged
merged 1 commit into from
May 3, 2024
Merged

[20945] Fix SecurityTest unittests memory error #4750

merged 1 commit into from
May 3, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Apr 30, 2024 •
edited by MiguelCompany
Loading

Description

This PR fixes an incorrect memory access error in the SecurityTests. The same CacheChange kx_change was being deleted and after accessed in the lambda defined within the expect_kx_exchange function.

The fix proposes separating the concerns of deletion and addition, defining a CacheChange for each one (in particular, a stack-allocated one for the addition).

Important Backports are not being included since backports from #4673 have not been merged and this could be cherry-picked.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL changed the title [20945] Fix SecurityTest unittests address errors [20945] Fix SecurityTest unittests memory error Apr 30, 2024
@Mario-DL Mario-DL added this to the v2.14.1 milestone Apr 30, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 30, 2024
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany merged commit 9928d1d into master May 3, 2024
12 of 17 checks passed
@MiguelCompany MiguelCompany deleted the fix/20945 branch May 3, 2024 11:56
Mario-DL added a commit that referenced this pull request May 6, 2024
@Mario-DL
Fix SecurityTest unittests memory error (#4750)
54d294a 
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL added a commit that referenced this pull request May 6, 2024
@Mario-DL
Fix SecurityTest unittests memory error (#4750)
4d573d9 
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL added a commit that referenced this pull request May 6, 2024
@Mario-DL
Fix SecurityTest unittests memory error (#4750)
28f8da9 
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany added a commit that referenced this pull request May 6, 2024
@mergify @MiguelCompany @Mario-DL
Fix leak in `SecurityManager::participant_volatile_message_secure_wri…
8252d15 
…ter_` (#4673) (#4725)

* Fix leak in SecurityManager::participant_volatile_message_secure_writer_ (#4673)

* Refs #20658. Add blackbox test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #20658. Add expectations to unit test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #20658. Fix issue.

Signed-off-by: Miguel Company <[email protected]>

* Refs #20658. Improve regression test.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 14ee8ef)

* Fix SecurityTest unittests memory error (#4750)

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
EduPonz pushed a commit that referenced this pull request May 9, 2024
@mergify @MiguelCompany @Mario-DL
Fix leak in `SecurityManager::participant_volatile_message_secure_wri…
0dbccb3 
…ter_` (#4673) (#4724)

* Fix leak in SecurityManager::participant_volatile_message_secure_writer_ (#4673)

* Refs #20658. Add blackbox test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #20658. Add expectations to unit test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #20658. Fix issue.

Signed-off-by: Miguel Company <[email protected]>

* Refs #20658. Improve regression test.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 14ee8ef)

* Fix SecurityTest unittests memory error (#4750)

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
EduPonz pushed a commit that referenced this pull request May 14, 2024
@mergify @MiguelCompany @Mario-DL
Fix leak in `SecurityManager::participant_volatile_message_secure_wri…
eb315e2 
…ter_` (#4673) (#4726)

* Fix leak in SecurityManager::participant_volatile_message_secure_writer_ (#4673)

* Refs #20658. Add blackbox test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #20658. Add expectations to unit test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #20658. Fix issue.

Signed-off-by: Miguel Company <[email protected]>

* Refs #20658. Improve regression test.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 14ee8ef)

* Fix SecurityTest unittests memory error (#4750)

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @MiguelCompany