-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20650] Examples refactor: Delivery mechanisms #4836
[20650] Examples refactor: Delivery mechanisms #4836
Conversation
e8894d6
to
8dee301
Compare
8dee301
to
1e2d3d0
Compare
1e2d3d0
to
365e649
Compare
6126fa8
to
31e1a55
Compare
31e1a55
to
608380b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some tests, we found out that there is an issue when setting the domain in the PubSub participant and the writer and the reader try to communicate through UDP. A deeper investigation is required.
608380b
to
b039789
Compare
b039789
to
217c436
Compare
|
||
switch (config.delivery_mechanism) | ||
{ | ||
case CLIParser::DeliveryMechanismKind::INTRA_PROCESS: // (It should never reach this section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case CLIParser::DeliveryMechanismKind::INTRA_PROCESS: // (It should never reach this section | |
case CLIParser::DeliveryMechanismKind::INTRA_PROCESS: |
4fc610f
to
5669527
Compare
2763008
to
782569b
Compare
5ea03b3
to
6e73700
Compare
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
6e73700
to
4434cb0
Compare
Description
This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.
In this delivery mechanisms example, the key changes are:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist