Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21099] X-Types examples #4924

Merged
merged 6 commits into from
Jun 14, 2024
Merged

[21099] X-Types examples #4924

merged 6 commits into from
Jun 14, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jun 10, 2024

Description

This PR adds an X-Types example in which a type is defined in run-time at the publisher side using the Dynamic Types API, and the subscriber discovers the type, creates a reader for it, and prints the received data.
This example is type compatible with the hello_world one (a compatibility test has been added for this).

This PR depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v3.0.0 milestone Jun 10, 2024
@EduPonz EduPonz force-pushed the examples/xtypes branch 3 times, most recently from 03d49e8 to a90f5d4 Compare June 14, 2024 05:13
@EduPonz EduPonz requested a review from Mario-DL June 14, 2024 05:14
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 14, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very meaningful example ! Leaving two NITs and a suggestion.
It seems that ShapesDemo Types should be regenerated in order to get Ubuntu CI running again

examples/cpp/xtypes/CLIParser.hpp Outdated Show resolved Hide resolved
examples/cpp/xtypes/CLIParser.hpp Outdated Show resolved Hide resolved
examples/cpp/xtypes/main.cpp Show resolved Hide resolved
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz merged commit 7cedc98 into master Jun 14, 2024
10 of 11 checks passed
@EduPonz EduPonz deleted the examples/xtypes branch June 14, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants