Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21159] Remove include/fastrtps #4930

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jun 11, 2024

Description

This PR removes the include/fastrtps directory completely.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/data/WriterProxyData.cpp Outdated Show resolved Hide resolved
@EduPonz EduPonz force-pushed the feature/cleanup_include_fastrtps branch 3 times, most recently from ed90eb3 to c1e5496 Compare June 17, 2024 09:13
@EduPonz EduPonz force-pushed the feature/cleanup_include_fastrtps branch from c1e5496 to 80463c2 Compare June 18, 2024 09:35
@EduPonz EduPonz requested a review from elianalf June 18, 2024 09:38
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 18, 2024
@EduPonz
Copy link
Author

EduPonz commented Jun 18, 2024

@richiprosima please test_3 discovery-server

elianalf
elianalf previously approved these changes Jun 18, 2024
@EduPonz EduPonz requested a review from elianalf June 18, 2024 10:34
@EduPonz EduPonz merged commit 8f4058b into master Jun 19, 2024
16 of 17 checks passed
@EduPonz EduPonz deleted the feature/cleanup_include_fastrtps branch June 19, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants