Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21314] Improve resilience against clock adjustments (backport #5018) #5190

Closed
wants to merge 1 commit into from

Commits on Sep 2, 2024

  1. Improve resilience against clock adjustments (#5018)

    * Use steady_clock instead of high_resolution_clock for status checks (high_resolution_clock might not be steady depending on STL impl)
    
    Signed-off-by: Matthias Schneider <[email protected]>
    
    * Use steady_clock instead for system_clock for calculating timeouts
    
    Signed-off-by: Matthias Schneider <[email protected]>
    
    * Use correct clock's duration for duration_cast
    
    Signed-off-by: Matthias Schneider <[email protected]>
    
    * Use Time_t::now()
    
    Signed-off-by: Matthias Schneider <[email protected]>
    
    * Fix build.
    
    Signed-off-by: Miguel Company <[email protected]>
    
    * Refs #21314. Refactor on DataWriterImpl.
    
    Signed-off-by: Miguel Company <[email protected]>
    
    * Refs #21314. Refactor on DataReaderImpl.
    
    Signed-off-by: Miguel Company <[email protected]>
    
    * Refs #21314. Refactor on StatefulWriter.
    
    Signed-off-by: Miguel Company <[email protected]>
    
    * Refs #21314. Protect current_time_since_unix_epoch against clock adjustments.
    
    Signed-off-by: Miguel Company <[email protected]>
    
    * Revert "Use steady_clock instead of high_resolution_clock for status checks (high_resolution_clock might not be steady depending on STL impl)"
    
    This reverts commit d69eb91.
    
    ---------
    
    Signed-off-by: Matthias Schneider <[email protected]>
    Signed-off-by: Miguel Company <[email protected]>
    Co-authored-by: Miguel Company <[email protected]>
    (cherry picked from commit ccc690c)
    
    # Conflicts:
    #	include/fastdds/rtps/writer/StatefulWriter.h
    #	src/cpp/fastdds/publisher/DataWriterImpl.cpp
    #	src/cpp/fastdds/subscriber/DataReaderImpl.cpp
    #	src/cpp/utils/time_t_helpers.hpp
    ma30002000 authored and mergify[bot] committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2bf2a29 View commit details
    Browse the repository at this point in the history