[21479] Allow runing CI on external contributions #5220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some logic to the CI to determine if an external contribution triggers the CI. In such a case, the CI avoids using the
external/add_label
action which is not allowed in external contribution cases.A deep research on the literature brings some information regarding possible security issues while using
pull_request_target
CI triggers. As long as we only use thepull_request
trigger, there is no need to include manual confirmation from a Collaborator with required permissions, from now on.NOTE: Adding the
skip-ci
label as long as the external contributions CI is tested from the following external PR:As part of the CI pipelines, this PR needs to be included also in the critical-security-fixes-only 2.6.x supported branch.
Bear in mind that cron workflows must be removed from the backports.
@Mergifyio backport 2.14.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist