-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21538] Allow all durability
configurations
#5224
Open
Mario-DL
wants to merge
7
commits into
master
Choose a base branch
from
feature/21538
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Dominguez <[email protected]>
…b test API to make it clearer Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
force-pushed
the
feature/21538
branch
from
September 11, 2024 19:42
0029486
to
456a976
Compare
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
September 11, 2024 19:42
Mario-DL
added
doc-pending
Issue or PR which is pending to be documented
versions-pending
and removed
ci-pending
PR which CI is running
labels
Sep 12, 2024
7 tasks
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
added
needs-review
PR that is ready to be reviewed
and removed
doc-pending
Issue or PR which is pending to be documented
versions-pending
labels
Sep 12, 2024
MiguelCompany
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my comments below, I think we can consider that we fully support PERSISTENT
durability, since I think it is what we currently support.
From the standard:
Data is kept on permanent storage, so that they can outlive a system session.
This means we could remove the warning on check_qos
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
force-pushed
the
feature/21538
branch
from
September 23, 2024 10:04
fca47eb
to
3be074c
Compare
MiguelCompany
approved these changes
Sep 23, 2024
MiguelCompany
added
blocked-till-branch-out
and removed
needs-review
PR that is ready to be reviewed
labels
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
PERSISTENT
durability, but behaving asTRANSIENT
.TRANSIENT
, if no persistence guid is given, it fallbacks toTRANSIENT_LOCAL
.make_transient()
make_persitent()
pubsub API to be clearer about the intention of making a transient or persistent endpoint.Contributor Checklist
versions.md
file (if applicable).durability
configurations Fast-DDS-docs#907Reviewer Checklist