Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21663] Fix request reply example isolated build #5236

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Sep 13, 2024

Description

This PR fixes a build issue in request reply example if built without using the -DCOMPILE_EXAMPLES=ON cmake flag when building Fast DDS project

Fixes #5231

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Sep 13, 2024
@JesusPoderoso JesusPoderoso added this to the v3.0.1 - Frozen ❄️ milestone Sep 13, 2024
@JesusPoderoso JesusPoderoso self-assigned this Sep 13, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 13, 2024
@JesusPoderoso JesusPoderoso removed the request for review from richiprosima September 13, 2024 10:27
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15 rsanchez15 merged commit 5abe0c0 into master Sep 13, 2024
14 checks passed
@rsanchez15 rsanchez15 deleted the hotfix/21663 branch September 13, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants