Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21672] Fix data race in TypeObjectFactory::get_instance #5238

Merged
merged 12 commits into from
Sep 17, 2024
Merged

[21672] Fix data race in TypeObjectFactory::get_instance #5238

merged 12 commits into from
Sep 17, 2024

Commits on Sep 13, 2024

  1. Refs #21664. Regression test. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c58dbe1 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Refs #21664. Improve synchronization in regression test. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0e3d4db View commit details
    Browse the repository at this point in the history

  2. Refs #21664. Return created instance to visualize data-race and make … 

    …test fail.

Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d618c39 View commit details
    Browse the repository at this point in the history

  3. Refs #21664. Just count the number of different instances. 

    This way we have a single final expectation.

Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bce24a7 View commit details
    Browse the repository at this point in the history

  4. Refs #21664. Avoid using g_instance inside the instance. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b74914e View commit details
    Browse the repository at this point in the history

  5. Refs #21664. Inject factory in all methods called inside `register_bu… 

    …iltin_annotations_types`.

Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bda703a View commit details
    Browse the repository at this point in the history

  6. Refs #21664. Use atomic enumeration to control the instance state. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b45877d View commit details
    Browse the repository at this point in the history

  7. Refs #21664. Uncrustify. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9039ad7 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Refs #21672. Notify condition from main thread. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    47adba9 View commit details
    Browse the repository at this point in the history

  2. Refs #21672. FIx EOL at end of file. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    25c64e8 View commit details
    Browse the repository at this point in the history

  3. Refs #21672. Refactor to create builtin objects inside factory constr… 

    …uctor.

Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    20d3974 View commit details
    Browse the repository at this point in the history

  4. Refs #21672. Uncrustify. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ce219a8 View commit details
    Browse the repository at this point in the history