Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21725] Update examples CMakeList to force default CMAKE_BUILD_TYPE #5360

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Oct 28, 2024

Description

This PR updates the examples CMakeList to build with Release CMake build type mode, if the mode has not been specified.

@Mergifyio backport 3.1.x 3.0.x

This PR is related to:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v3.2.0 milestone Oct 28, 2024
@JesusPoderoso JesusPoderoso self-assigned this Oct 28, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 28, 2024
@JesusPoderoso JesusPoderoso removed the request for review from richiprosima October 28, 2024 13:15
@rsanchez15 rsanchez15 merged commit 82059aa into master Nov 5, 2024
16 of 17 checks passed
@rsanchez15 rsanchez15 deleted the hotfix/21725 branch November 5, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants