Handle IllegalStateException in file:directory-list#2
#5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizzzz
approved these changes
Oct 16, 2023
reinhapa
approved these changes
Oct 16, 2023
|
We should consider adding a test for this. |
line-o
changed the title
adamretter
suggested changes
Oct 16, 2023
line-o
force-pushed
the
fix/5028
branch
2 times, most recently
from
f578a61 to
76e28c4
Compare
|
Test added |
line-o
force-pushed
the
fix/5028
branch
2 times, most recently
from
63ff6e5 to
c3fd24b
Compare
fixes eXist-db#5028 The Java code of DirectoryList can throw an IllegalStateException when a non-existent directory is supplied as its first argument. This exception class is now handled in file:list#2. Additionally, the raised error now has a proper code `file:DIRECTORY_NOT_FOUND`. This will allow us in the future to add proper error codes to more errors raised by this module.
|
6.x.x backport is #5093 |
dizzzz
approved these changes
Oct 16, 2023
adamretter
reviewed
Oct 16, 2023
extensions/modules/file/src/main/java/org/exist/xquery/modules/file/FileErrorCode.java
Outdated
Show resolved
Hide resolved
reinhapa
requested changes
Oct 17, 2023
extensions/modules/file/src/main/java/org/exist/xquery/modules/file/DirectoryList.java
Show resolved
Hide resolved
reinhapa
approved these changes
Oct 17, 2023
adamretter
changed the title
file:directory-list#2
|
SonarCloud Quality Gate failed.
|
adamretter
approved these changes
Oct 19, 2023
|
Thanks everybody! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5028
The Java code of DirectoryList can throw an IllegalStateException when a non-existent directory is supplied as its first argument. This exception class is now handled in file:list#2.
This is a forward port of #5061
Thanks to @nverwer for bringing this up and also finding the fix.