[4.x.x] Fix an issue where XQuery Trigger state may leak #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinhapa
approved these changes
Oct 8, 2024
dizzzz
approved these changes
Oct 9, 2024
|
all builds fail... |
Yes, this needs #5468 first |
|
#5468 is in.... (since a minute) |
XQuery trigger not found is acceptable behaviour (logs a debug message only, could get very chatty logs otherwise). BUT the exit path from the exception fails to tidy up the per-thread trigger state. This has been observed to leak memory; the per-thread doesn’t get cleaned up until the thread is deleted, and the trigger cyclic-check stack just builds up. So we clean up the trigger state when a trigger is not found. Closes eXist-db#5459
We may leak trigger states to thread local which can potentially occur when the specified XQueryTrigger library module is not available in the database Closes eXist-db#5459
adamretter
force-pushed
the
4.x.x/hotfix/xquery-trigger-leak
branch
from
6e4286a to
bdb703f
Compare
|
@dizzzz The 1 flaky test failure on Windows in CI for |
reinhapa
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5481
NOTE: Needs #5468 merged first and then this needs to be rebased