Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WIZnet W55RP20-EVB-Pico board #2555

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

wiznet-mason
Copy link
Contributor

The W55RP20 is a SiP chip that integrates the RP2040 with WIZnet's W5500 and 2MB Flash.
https://docs.wiznet.io/Product/ioNIC/W55RP20/overview

@earlephilhower
Copy link
Owner

Thanks! Looks like you need to check in the modified package/package_pico_index.template.json file (modified/built by makeboards.py per the CI failure.

@maxgerhardt
Copy link
Contributor

@wiznet-mason recheck CI, it's complaining about

/home/runner/arduino_ide/hardware/pico/rp2040/libraries/lwIP_w55rp20/src/wiznet_pio_spi.c:79:23: error: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Werror=sign-compare]
   79 |     for (int i = 0; i < count_of(wiznet_pio_spi_state); i++) {
      |                       ^
cc1: all warnings being treated as errors

@earlephilhower
Copy link
Owner

Ping, @wiznet-mason . We can't edit your repo, so you'll need to fix the CI warnings from gcc (use File->Preferences->Compiler Warnings->All to mimic the -wall -werror we run in CI).

@wiznet-mason
Copy link
Contributor Author

Thank you very much for all the advice. I’ll try again and commit.

@earlephilhower
Copy link
Owner

Looks like we're all good now, thanks!

@earlephilhower earlephilhower merged commit b0e7ad3 into earlephilhower:master Oct 29, 2024
26 checks passed
@wiznet-mason
Copy link
Contributor Author

Thank you very much!

@maxgerhardt
Copy link
Contributor

Aww, the board was not added to the README.md list though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants