Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

committed ab-homepage-hero-downoad-copy-test results #701

Merged
merged 2 commits into from
Oct 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions website/_includes/core/call-to-action.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
>
Get Started Free
</a>
<div class="text-center text-slate-400 text-l">
Open Source on <a class="underline" href="https://github.com/earthly/earthly">GitHub</a>
<div id="earthly-core-hero-install-no-login">
<p class="text-center xl:text-left text-slate-400 text-sm">Open Source on <a class="underline" href="https://github.com/earthly/earthly">GitHub</a>&nbsp;&nbsp;|&nbsp;&nbsp;<a class="underline" href="https://earthly.dev/get-earthly" onclick="earthlyCoreHeroInstallNoLoginClick()">Install Earthly w/o logging in</a></p>
</div>
</div>

Expand All @@ -21,4 +21,11 @@
label: 'earthly-core-get-started-free-click'
});
}

function earthlyCoreHeroInstallNoLoginClick() {
analytics.track('earthly-core-hero-install-no-login-click', {
category: 'Install No Login Click',
label: 'earthly-core-hero-install-no-login-click'
});
}
</script>
8 changes: 4 additions & 4 deletions website/_includes/growthbook.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script src="https://cdn.jsdelivr.net/npm/@growthbook/growthbook/dist/bundles/index.js"></script>
<script>
// Uncomment for testing
// Uncomment uuidv4() for testing / Uncomment getAnalyticCookie() for production
//var earthlyID = uuidv4();
var earthlyID = getAnalyticCookie();

Expand All @@ -27,8 +27,8 @@
gb.loadFeatures({ autoRefresh: true, timeout: 2000 }).then(() => {
// console.log("Features loaded");

// Gavin, homepage-hero-install-no-login-test, 20230926: Configured for homepage-hero-install-no-login-test
if(document.getElementById("homepage-hero-install-no-login-control")){
// Example
/*if(document.getElementById("homepage-hero-install-no-login-control")){
//console.log("control element rendered");

const testOn = gb.isOn("homepage-hero-install-no-login")
Expand All @@ -40,6 +40,6 @@
document.getElementById("homepage-hero-install-no-login-test").style.display = "none";
}
}
});
});*/
});
</script>
2 changes: 1 addition & 1 deletion website/_includes/head.html
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

{% if jekyll.environment == "production" %}
{%- include segment.html -%}
{%- include growthbook.html -%}
<!-- {%- include growthbook.html -%} -->
{%- include clearbit.html -%}
{% endif %}

Expand Down
7 changes: 1 addition & 6 deletions website/_includes/home/v2/hero.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,7 @@ <h1 class="font-medium text-5xl sm:text-7xl text-center xl:text-left text-slate-
</a>
</div>

<!-- Gavin, homepage-hero-install-no-login-test, 20230926: Added div, p inside existed -->
<div id="homepage-hero-install-no-login-control">
<p class="text-center xl:text-left text-slate-400">Open Source on <a class="underline" href="https://github.com/earthly/earthly">GitHub</a></p>
</div>
<!-- Gavin, homepage-hero-install-no-login-test, 20230926: Added div -->
<div id="homepage-hero-install-no-login-test" style="display: none;">
<div id="homepage-hero-install-no-login">
<p class="text-center xl:text-left text-slate-400 text-sm">Open Source on <a class="underline" href="https://github.com/earthly/earthly">GitHub</a>&nbsp;&nbsp;|&nbsp;&nbsp;<a class="underline" href="https://earthly.dev/get-earthly" onclick="homepageHeroInstallNoLoginClick()">Install Earthly w/o logging in</a></p>
</div>

Expand Down
Loading