-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing unmapped contigs #11
Conversation
Hello @RSWilson1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-08-02 13:22:51 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @RSWilson1)
gene_annotation2bed.py
line 859 at r2 (raw file):
for contig in unknown_contigs["chromosome"].unique(): print(contig) print(f"Total unknown contig rows: {len(unknown_contigs)}")
since these are being removed can you make the message to the user explicit to say they have been omitted from the output
Code quote:
print(f"Total unknown contig rows: {len(unknown_contigs)}")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RSWilson1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RSWilson1)
Fixes error creating IGV reports
Removed entries in BED with contigs which don't map to chromosome.
i.e. NT_ ow NW_ prefixed contigs see: https://hgvs-nomenclature.org/stable/background/refseq/.
This change is