Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unmapped contigs #11

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Removing unmapped contigs #11

merged 6 commits into from
Aug 2, 2024

Conversation

RSWilson1
Copy link
Collaborator

@RSWilson1 RSWilson1 commented Aug 1, 2024

Fixes error creating IGV reports

Removed entries in BED with contigs which don't map to chromosome.
i.e. NT_ ow NW_ prefixed contigs see: https://hgvs-nomenclature.org/stable/background/refseq/.


This change is Reviewable

@RSWilson1 RSWilson1 added the bug Something isn't working label Aug 1, 2024
@RSWilson1 RSWilson1 requested a review from jethror1 August 1, 2024 13:32
@RSWilson1 RSWilson1 self-assigned this Aug 1, 2024
@pep8speaks
Copy link

pep8speaks commented Aug 1, 2024

Hello @RSWilson1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 854:80: E501 line too long (95 > 79 characters)
Line 858:80: E501 line too long (88 > 79 characters)
Line 859:80: E501 line too long (92 > 79 characters)

Comment last updated at 2024-08-02 13:22:51 UTC

Copy link
Contributor

@jethror1 jethror1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @RSWilson1)


gene_annotation2bed.py line 859 at r2 (raw file):

    for contig in unknown_contigs["chromosome"].unique():
        print(contig)
    print(f"Total unknown contig rows: {len(unknown_contigs)}")

since these are being removed can you make the message to the user explicit to say they have been omitted from the output

Code quote:

    print(f"Total unknown contig rows: {len(unknown_contigs)}")

Copy link
Contributor

@jethror1 jethror1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RSWilson1)

Copy link
Contributor

@jethror1 jethror1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RSWilson1)

@jethror1 jethror1 merged commit 1866644 into main Aug 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants