-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix batchspawner for JupyterHub 3.0 #18390
Fix batchspawner for JupyterHub 3.0 #18390
Conversation
@boegelbot please test @ generoso |
@casparvl: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1650204999 processed Message to humans: this is just bookkeeping information for me, |
@boegelbot please test @ jsc-zen2 |
@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1650206520 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegelbot |
Test report by @casparvl |
Test report by @verdurin |
Hmm, not sure why the two remote test builds are failing. |
Maybe they triggered at the same time as my rebuild off |
@boegelbot please test @ generoso |
@casparvl: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1651692597 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen2 |
yep, that seems to have been the issue. The other run was rebuilding |
@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1651709903 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Going in, thanks @casparvl! |
(created using
eb --new-pr
)Batchspawner 1.2.0 doesn't work with JupyterHub3.X. Main contains the necessary fixes, but no release is available. Installing from commit
2a9eda0
does contain the necessary support.Note that this avoids the
error thrown by batchspawner 1.2.0 (in combination with JH 3.0).
See jupyterhub/batchspawner#277