Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{chem}[foss/2023a] TINKER v8.11.3 #21098

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Jul 31, 2024

(created using eb --new-pr)

  • use generic CMakeMake easyblock instead of custom tinker.py

@smoors smoors added the new label Jul 31, 2024
@smoors smoors marked this pull request as draft July 31, 2024 16:49
@smoors smoors marked this pull request as ready for review August 1, 2024 12:08
@smoors smoors changed the title {chem}[foss/2023a] Tinker v8.11.3 {chem}[foss/2023a] TINKER v8.11.3 Aug 5, 2024
@smoors smoors added update and removed new labels Aug 5, 2024
@smoors
Copy link
Contributor Author

smoors commented Aug 5, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=21098 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21098 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14020

Test results coming soon (I hope)...

- notification for comment with ID 2269688369 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f53f7bd2a8d6f0d7be4ac6c69d7f785e for a full test report.

@smoors
Copy link
Contributor Author

smoors commented Aug 6, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21098 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21098 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4643

Test results coming soon (I hope)...

- notification for comment with ID 2270556591 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/5a3685701483196f31f4eba1e10dc7e2 for a full test report.

srcdir = 'cmake'

# copy executables into bin directory
test_cmd = 'find -maxdepth 1 -mindepth 1 -type f -executable |xargs -I % cp % ../tinker/bin/ && '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear what this is doing. If it is copying the binaries into bin in the installation directory, this needs to be done in the install step or post-install step because the test step can be skipped. If it is copying in a bin folder inside the build directory, I fail to see why that copy is needed as that bin folder is not in PATH.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the binaries need to be in the bin directory because their paths are hardcoded in the test scripts.

i have now patched the test scripts instead, which makes it more clear why this is needed, see 166f3a6

@smoors
Copy link
Contributor Author

smoors commented Sep 22, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=21098 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21098 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14325

Test results coming soon (I hope)...

- notification for comment with ID 2366491765 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c3cd88fdd8e449251ab712b3a17cdfcf for a full test report.

@smoors
Copy link
Contributor Author

smoors commented Sep 22, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21098 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21098 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4930

Test results coming soon (I hope)...

- notification for comment with ID 2366715025 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/ffcd27a9d171dd73a0fbd1c341c35dfa for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants