-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{chem}[foss/2023a] TINKER v8.11.3 #21098
base: develop
Are you sure you want to change the base?
{chem}[foss/2023a] TINKER v8.11.3 #21098
Conversation
@boegelbot: please test @ generoso |
@smoors: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2269688369 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2270556591 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
srcdir = 'cmake' | ||
|
||
# copy executables into bin directory | ||
test_cmd = 'find -maxdepth 1 -mindepth 1 -type f -executable |xargs -I % cp % ../tinker/bin/ && ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear what this is doing. If it is copying the binaries into bin
in the installation directory, this needs to be done in the install step or post-install step because the test step can be skipped. If it is copying in a bin
folder inside the build directory, I fail to see why that copy is needed as that bin
folder is not in PATH
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the binaries need to be in the bin directory because their paths are hardcoded in the test scripts.
i have now patched the test scripts instead, which makes it more clear why this is needed, see 166f3a6
@boegelbot: please test @ generoso |
@smoors: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2366491765 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2366715025 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
(created using
eb --new-pr
)CMakeMake
easyblock instead of customtinker.py