Rename SOURCE_STEP to EXTRACT_STEP #4629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
source-step
branch
2 times, most recently
from
c8f9611
to
2945e38
Compare
boegel
requested changes
Sep 11, 2024
Flamefire
force-pushed
the
source-step
branch
3 times, most recently
from
9847816
to
375b04d
Compare
|
@Flamefire Merge conflict to fix, probably a trivial one... |
``` '--sourcepath=%s' % self.test_sourcepath, '--buildpath=%s' % self.test_buildpath, '--installpath=%s' % self.test_installpath, ``` is not required because the test setup sets those via env variables.
Adjust tests to take that into account and add tests to check that the old name causes a proper error. Add such error handling for the `skipsteps` EC parameter. Split up `test_skip` into more focused sub tests.
This fixes `test_toy_multi_deps` which restores the environment in the middle of the test and then misses the --sourcepath modification done at test setup.
Flamefire
force-pushed
the
source-step
branch
from
375b04d
to
65b61be
Compare
|
Jep, one of the test fixes I had opened a separate PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust tests to take that into account and add tests to check that the
old name causes a proper error.
Add such error handling for the
skipstepsEC parameter.Split up
test_skipinto more focused sub tests to allow adding the new (negative/failure) test of skipsteps to one of those.Also a fix for
test_compiler_cacheand a bit cleanup to avoid copying the same superflous parameters in the new tests.Fixes #4627