Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

take into account alternate sysroot for /bin/bash used by run_cmd #4646

Merged
merged 5 commits into from
Sep 18, 2024
Merged

take into account alternate sysroot for /bin/bash used by run_cmd #4646

merged 5 commits into from
Sep 18, 2024

Commits on Sep 18, 2024

  1. Make sure the run_cmd respects sysroot when picking the shell, i.e. u… 

    …se sysroot/bin/bash instead of /bin/bash if sysroot is set
    casparvl casparvl committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7bf4073 View commit details
    Browse the repository at this point in the history

  2. Make sure we only check for sysroot after set_up_configuration is cal… 

    …led. Any command run before that with run_cmd should use the regular /bin/bash
    casparvl casparvl committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    73a53a8 View commit details
    Browse the repository at this point in the history

  3. Also add with_sysroot=False here

    casparvl casparvl committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    347e64c View commit details
    Browse the repository at this point in the history

  4. Fix indent

    casparvl casparvl committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    165fe79 View commit details
    Browse the repository at this point in the history

  5. be a bit more careful with sysroot in run_cmd, add logging + add dedi… 

    …cated test for run_cmd using with_sysroot=True
    @boegel
    boegel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f7c3cb1 View commit details
    Browse the repository at this point in the history