-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: API #391
Conversation
This comment has been minimized.
This comment has been minimized.
Should it be eta_squared()? |
hehe yeah |
@strengejacke I am working here on allowing full support for When I'm done, ideally, I'll let you know when this is done - then we can think about how to utilize these changes in |
What does parameters need from effectsize? Can we eliminate that entirely? |
It gives users an option to append the effect sizes to the parameters' table. Historically, all the Perhaps, in the future, this can be handed off to |
Yeah, that's something that would be better in report I think, same with, eg, getting both raw and exponentiated coefficients in one table. Is this specifically for ANOVA type contexts? |
For regression models (for standardized slopes), ANOVA tables, and some |
This might be tricky for standardized coefficients. For |
Not only the standardization would neen to be moved to parameters, also the ANOVA effect size functions and the |
Post-hoc standardize_parameters() API is getting too big - merging this for now. |
There are 3 major functions that need a reliable API. This is the goal for version 1.0.0
eta_squared()
Essentially any model that can produce one of 3 tables will be supported:
And also:
parameters_model
- it should be possible to get the effect size without having to also callparameters
!"object_name"
attribute missing for ANOVA-like outputs parameters#624standardize.default()
standardize.mlm()
- waiting for standardization of matrix converts it to vector datawizard#42standardize.coxph()
standardize_parameters()
standardize
.standardize_info
And also:
parameters_model
- it should be possible to get the effect size without having to also callparameters
!standardize_parameters()
usestandardize_parameters.parameters_model()
for complete usage.standardize_info()