Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MX switch step file #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add MX switch step file #25

wants to merge 1 commit into from

Conversation

earth75
Copy link

@earth75 earth75 commented Nov 12, 2023

No description provided.

@ebastler
Copy link
Owner

Hi! Do you have a source for this step, ideally with permission to use?

I was planning to add full 3d models for stabs and switches eventually, but we are still unsure how to actually handle these models so that they will not significantly slow down and clutter 3d viewer - we need some way to toggle them properly. Once we decided on a course of action, it will be added.

@earth75
Copy link
Author

earth75 commented Nov 25, 2023

Hi,

I found a model which looked good and had a low vertex count (No 3D scan or sculpt mesh). Then I edited it so that the dimentions match this spec : https://www.cherrymx.de/en/dev.html

Then I added materials, so it looks better and made sure that it sits flush and centered on the pcb footprint.

It does not affect the framerate so much in the 3d viewer, even with an 1800 keyboard. (And I have a 10-year-old desktop with a SATA drive!)
image

@HigherOrderLogic
Copy link

Hi, is there any update/progess made for this PR?

@ebastler
Copy link
Owner

Hi, is there any update/progess made for this PR?

Not really - it would need marv and me to sit down together and decide how to handle 3D models for everything switch-related from now on. Adding them as default on would - imo - clutter the 3D preview too much (and lead to huge loading times). So far we did not find the time to decide.

Once we tackle it, I would like to add stabs and switches for MX and Choc. It might take a while though. Recently all I did for the lib was stuff I needed for a project at hand due to a lack of time. It could use a bunch of tweaks and optimizations in general.

Sorry for that!

@HigherOrderLogic
Copy link

Understandable, thanks for your answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants